Code after removing certain smells #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry, but did you test your changes? Your code does not even compile... Neither is it formatted according to our style guide. |
|
While your code compiles now, it looks like you didn't test your changes. You broke the application. And still, the code is not formatted. I'll close this for now. I don't see any value in these changes. |
|
That's fine, I understand. Thanks for consideration though.
…On Tue, Dec 5, 2023, 4:32 PM Hannes Braun ***@***.***> wrote:
While your code compiles now, it looks like you didn't test your changes.
You broke the application. And still, the code is not formatted.
Also, the .VSCodeCounter directory should not be part of this pull
request. And a lot of your refactoring just adds complexity without adding
any value. Or for example why move the code for intersecting a line into
the Vec3f class? That's specific to a line, so the code needs to stay
there. That has nothing to do with a Vec3f.
I'll close this for now. I don't see any value in these changes.
—
Reply to this email directly, view it on GitHub
<#135 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APGUXSGCQKR4SYID3VHBGTDYH6AEVAVCNFSM6AAAAAA75EZAN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRGU3DQMRYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored the code a little. Fixed 4 implementation smells and 5 design smells as part of my university assignment. Hope you find them useful :)